[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Fix moving cursor in org-set-tags-command
From: |
Matt Lundin |
Subject: |
[PATCH] Fix moving cursor in org-set-tags-command |
Date: |
Thu, 07 May 2020 19:20:09 -0500 |
Commit 44ec473c199262d89b372d8a6cd35bed7672164d from Feb. 23 causes
org-set-tags-command to move the cursor forward 1 char when situated on
headline asterisks.
So if I am on the following level 1 headline with the cursor on the
asterisk as below...
* Headline
^
...and I call org-set-tags command, it moves the cursor forward one space:
* Headline :tag:
^
This is causes problems with org-speed-keys, which requires that the
cursor remain on the headline.
This commit modified a previous change on Feb. 21
(450452de4b790706d187291f9f71a286f8f62004). But that commit also had
problems, since it would move the cursor one asterisk forward on
headlines > 1, thus also interfering with org-speed-keys. In my view
org-set-tags-command should not move the cursor except to fix the very
specific thing that commit 450452de4b was meant to fix: namely the
cursor moving when on a blank headline: i.e., from here...
***
^
...to here...
*** :tag:
^
I've attached a patch that corrects the problem, but it would be ideal
if we figured out why the cursor is moving in the first place.
Best,
Matt
>From ae5cf0e1110241426e49f573219e9740c25bf8ea Mon Sep 17 00:00:00 2001
From: Matt Lundin <address@hidden>
Date: Thu, 7 May 2020 19:06:08 -0500
Subject: [PATCH 1/1] Fix bug that placed cursor incorrectly when setting tags
* lisp/org.el: (org-set-tags-command) Only fix cursor position in very
specific circumstances (i.e., when cursor is on an empty headline).
---
lisp/org.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index dd017e662..0e4fd7be1 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11846,8 +11846,9 @@ in Lisp code use `org-set-tags' instead."
(org-set-tags tags)))))
;; `save-excursion' may not replace the point at the right
;; position.
- (when (save-excursion (skip-chars-backward "*") (bolp))
- (forward-char))))
+ (and (looking-at " ")
+ (string-match "\\*+" (buffer-substring (point-at-bol) (point)))
+ (forward-char))))
(defun org-align-tags (&optional all)
"Align tags in current entry.
--
2.26.2
- [PATCH] Fix moving cursor in org-set-tags-command,
Matt Lundin <=