|
From: | address@hidden |
Subject: | Re: [PATCH] improve ol-man.el with occur searching |
Date: | Mon, 17 Aug 2020 11:22:47 +0800 |
Hello,
"numbchild@gmail.com" <numbchild@gmail.com> writes:
> With this patch, ol-man.el link type can be a link like this:
> ```org
> [[man:grep::--extended-regexp][grep --extended-regexp]]
> ```
> Occur will auto search "--extended-regexp" string in man page buffer.
Thanks.
> +PATH should be a topic that can be thrown at the man command.
> +If PATH contains extra ::STRING which will use `occur' to search
> +matched strings in man buffer."
> + (string-match "\\(.*?\\)\\(?:::\\(.*\\)\\)?$" path)
> + (let* ((command (match-string 1 path))
> + (search (match-string 2 path)))
> + (funcall org-man-command command)
> + (with-current-buffer (concat "*Man " command "*")
This should only be called if search is non-empty.
> + (occur search))))
Why occur? Org uses `search-forward' for [[foo.org::text]] text links,
and uses `occur' with [[foo.org::/text/]] links.
Wouldn't it be more idiomatic to use a regular text search here?
Regards,
--
Nicolas Goaziou
0001-ol-man.el-Add-searching-support-in-man-page-buffer.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |