[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Expanded ob-python results handling and plotting
From: |
Kyle Meyer |
Subject: |
Re: [PATCH] Expanded ob-python results handling and plotting |
Date: |
Sat, 29 Aug 2020 16:14:45 -0400 |
Jack Kamm writes:
> The attached patch adds ob-python value results handling for the
> following types of results:
>
> - Dictionaries
> - Numpy arrays
> - Pandas dataframes
> - Matplotlib figures
Thanks. Just a couple of drive-by comments...
> + try:
> + import pandas as pd
> + except ModuleNotFoundError:
ModuleNotFoundError wasn't added until Python 3.6, so I think it'd be
better to use its parent class, ImportError.
> + pass
> + else:
> + if isinstance(result, pd.DataFrame):
> + result = [[''] + list(result.columns), None] + \
> +[[i] + list(row) for i, row in result.iterrows()]
Should handling of Series also be added?