[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Async session eval (2nd attempt)
From: |
Timothy |
Subject: |
Re: [PATCH] Async session eval (2nd attempt) |
Date: |
Mon, 01 Mar 2021 14:22:56 +0800 |
User-agent: |
mu4e 1.4.15; emacs 27.1 |
Jack Kamm <jackkamm@gmail.com> writes:
> I'm attaching an updated patch rebased on master.
Fantastic. Thanks for doing this.
> ob-python session blocks don't use "return", so this should just be:
Ah, oops 😛
> The non-session case is substantially different, and I think it would
> probably require a separate implementation.
I see, fair enough. I haven't looked at the internals myself.
> One possible approach would be to modify ob-eval.el, so that
> org-babel--shell-command-on-region uses make-process instead of
> process-file.
>
> I agree it would be nice to have, but it would take a bit of work to
> figure it all out, and there is already ob-async.el [1] that implements
> non-session async for all languages. (I wish it could be brought into
> org-mode, but it probably can't, because it depends on the external
> async.el.)
Interesting that you use a different async method.
>> p.s. After this is merged, it would be great to see support for other
>> languages grow :)
>
> I also have an async implementation for ob-R that's ready after this is
> merged :)
Brilliant! I can't wait.
I know Bastien has found himself unfortunately busy as of late (which I
think is why he's looking to have someone else take over as project
lead), but please don't be disheartened by the slow progress with
getting this merged! I can assure you that quite a few people are
watching this with keen interest :)
All the best,
Timothy.
- Re: [PATCH] Async session eval (2nd attempt),
Timothy <=