[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix erroneous tangling of blocks
From: |
Timothy |
Subject: |
Re: [PATCH] Fix erroneous tangling of blocks |
Date: |
Thu, 01 Jul 2021 21:38:42 +0800 |
User-agent: |
mu4e 1.4.15; emacs 28.0.50 |
HI Jacopo,
I've just taken a look at your patch and it looks good :) glad to see
you've also followed the commit message format. I hope this gets merged
soon.
--
Timothy
p.s. Just a little note for the future: it's good if you have full
sentences in the description of the changes.
Jacopo De Simoi <jacopods@protonmail.com> writes:
> Dear All,
>
> Please find attached a patch (against master) which takes care of the
> following issue. Assume I have a block like this
>
> #+begin_src sh :tangle no
> This should not be tangled
> #+end_src
>
> Then the block is correctly ignored when tangling the whole file, but
> erroneously tangled (to a file named "no") when tangling is run with the
> universal argument (so that only the current block should be tangled)
>
> This happens because the check for the "no" option is not performed when
> tangling a single block. In the proposed patch I address this issue by
> checking for the "no" option in the function org-babel-effective-tangled-
> filename