Re: citations: rx problems with emacs-26.3

[Axel Kielhorn]

> Am 09.08.2021 um 19:18 schrieb Maxim Nikulin <manikulin@gmail.com>:
> 
> On 08/08/2021 21:14, Nicolas Goaziou wrote:
>> Maxim Nikulin writes:
>>> I have noticed another problem with
>>> a lot of pcase branches in `org-cite-natbib--style-to-command' in and
>>> my experience is not enough to resolve it. On attempt to
>>> byte-compile-file
>>> the following error is reported after significant delay (and CPU fan
>>> becomes more noisy)
>>> 
>>> oc-natbib.el:108:9:Error: Bytecode overflow
>> Fixed. Thank you.
> 
> Nice. Perhaps `org-cite-biblatex-export-citation' should be fixed in a 
> similar way. There is no error yet but compiled file is significantly blown 
> up:
> 
> -rw-rw-r-- 1 ubuntu ubuntu 13383 Aug  9 02:17 lisp/oc-biblatex.el
> -rw-rw-r-- 1 ubuntu ubuntu 48906 Aug  9 17:06 lisp/oc-biblatex.elc
> 
> There are a couple of issues with "make single" for emacs-25.2:

There are still problems with Emacs 26.3

From making up1 from todays 01877f480:

Compiling /Users/axel/src/Emacs/org-mode/lisp/ob-C.el...
Eager macro-expansion failure: (error "rx form ‘regexp’ requires args 
satisfying ‘stringp’")

In toplevel form:
oc-basic.el:648:1:Error: Unknown rx form ‘literal’
Compiling /Users/axel/src/Emacs/org-mode/lisp/oc-biblatex.el...

In toplevel form:
oc-biblatex.el:248:1:Error: Unknown rx form ‘anychar’
Compiling /Users/axel/src/Emacs/org-mode/lisp/oc-csl.el...

In toplevel form:
oc-csl.el:255:1:Error: rx form ‘regexp’ requires args satisfying ‘stringp’

In toplevel form:
oc.el:866:1:Error: rx form ‘regexp’ requires args satisfying ‘stringp’
In end of data:
org-compat.el:1255:1:Warning: the function ‘directory-empty-p’ is not known to
    be defined.

Eager macro-expansion failure: (error "Unknown rx form ‘literal’“)

The patch from Maxim Nikulin fixes these for me.

Greetings Axel