[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-form
From: |
Timothy |
Subject: |
Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items |
Date: |
Tue, 31 Aug 2021 21:55:09 +0800 |
User-agent: |
mu4e 1.6.5; emacs 28.0.50 |
Hi Anders,
Did you have any thoughts on Nicolas’ comments?
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> Anders Johansson <mejlaandersj@gmail.com> writes:
>
>> org-duration-from-minutes was called with canonical = t, but without
>> providing a corresponding format only using the canonical units. This
>> broke if the user’s org-duration-format used other than the canonical
>> units.
>
> I think a proper fix would be to change `org-duration-from-minutes’ so
> it removes any unknown unit from what is provided from fmt or
> `org-duration-format’, and defaults to (special . h:mm) if nothing is
> left.
>
> WDYT?
All the best,
Timothy