[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken |
Date: |
Sat, 16 Oct 2021 14:52:42 +0800 |
Max Nikulin <manikulin@gmail.com> writes:
> It seems, each case of `org-no-popups' may require specific code. I have
> tried to take some code related to completion. It overrides
> display-buffer-base-action, but something more is required for
> pop-up-frames.
I think you went too far. display-buffer-base-action is mostly for user
to specify. We should not override it. If user needs adjustments for
*Org Help*, it is always possible using a custom function inside
display-buffer-base-action. I do not think that we need to do this job
for the user.
>From my perspective, there is no need to prevent users from shooting
their own leg (we are in Emacs after all). The cases we may need to
interfere are: (1) when some user customisations are mostly ok, except
they affect Org's usability, and the user has no easy way to fix it; (2)
when some customisation is very common and we significantly help many
users by supporting such customisation in Org itself.
I think pop-up-windows customisation qualifies for "(1)". Not
display-buffer-base-action.
Best,
Ihor
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, (continued)
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Max Nikulin, 2021/10/12
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Marco Wahl, 2021/10/12
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Ihor Radchenko, 2021/10/12
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Marco Wahl, 2021/10/13
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Max Nikulin, 2021/10/13
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Eric S Fraga, 2021/10/13
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Marco Wahl, 2021/10/14
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Ihor Radchenko, 2021/10/14
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Max Nikulin, 2021/10/14
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Max Nikulin, 2021/10/15
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken,
Ihor Radchenko <=
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Max Nikulin, 2021/10/17
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Eric S Fraga, 2021/10/18
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Max Nikulin, 2021/10/18
- Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken, Eric S Fraga, 2021/10/19
Re: [BUG] Org 9.5: org-goto UI seems broken, Adam Porter, 2021/10/05