[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 4a1f69ebca 2/2: Use (TICKS . HZ) for current-time etc.
From: |
Po Lu |
Subject: |
Re: master 4a1f69ebca 2/2: Use (TICKS . HZ) for current-time etc. |
Date: |
Wed, 27 Apr 2022 15:20:16 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Mark Barton <mbarton98@gmail.com> writes:
> The change also breaks org-file-newer-than-p function that triggered
> the debugger while loading my init that uses org babel. I was able to
> use the example of the patch that Paul Eggert provided earlier for the
> desktop-save to add the time-convert to “fix” org-file-newer-than-p as
> shown below. Not positive that I needed to change it in both places,
> but it works for me now on macOS Monterey.
>
> modified lisp/org/org-macs.el
> @@ -264,8 +264,8 @@ org-file-newer-than-p
> ;; (e.g. HFS+) do not retain any finer granularity. As
> ;; a consequence, make sure we return non-nil when the two
> ;; times are equal.
> - (not (time-less-p (cl-subseq (nth 5 (file-attributes file)) 0 2)
> - (cl-subseq time 0 2)))))
> + (not (time-less-p (cl-subseq (time-convert (nth 5 (file-attributes
> file)) 'list) 0 2)
> + (cl-subseq (time-convert time 'list) 0 2)))))
Isn't the fact that changes are needed in multiple pieces of in-tree
code a wake-up call demonstrating it's too early to change the default
time format?