[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] update ob-scheme to latest changes in geiser package
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] update ob-scheme to latest changes in geiser package |
Date: |
Wed, 27 Apr 2022 16:44:00 +0800 |
Tim Van den Langenbergh <tmt_vdl@gmx.com> writes:
> I have taken the liberty of reformatting the patch you created for ob-scheme.
> You can find it enclosed.
Thanks! Since Felipe has no objections, your patch should be good to apply.
> If it is fine with you and the org-mode maintainers it can be applied as-is,
> particularly since it is a tiny change.
> I have also added some additional information to the commit message, such as
> when the `geiser-eval-region/wait' function was introduced.
Could you kindly add the geiser version info as a comment inside code?
Commit message is an unlikely place to be checked regularly and be
noticed as geiser is updated in future.
Comments are generally preferred over commit messages:
https://orgmode.org/worg/org-contribute.html#commit-messages ->
-> https://git.savannah.gnu.org/cgit/emacs.git/plain/CONTRIBUTE
>> - Explaining the rationale for a design choice is best done in comments
>> in the source code. However, sometimes it is useful to describe just
>> the rationale for a change; that can be done in the commit message
>> between the summary line and the file entries.
Best,
Ihor