Re: PATCH: [PATCH] Allow bulk agenda actions to take log notes

[Ihor Radchenko]

Max Mikhanosha <max.mikhanosha@gmail.com> writes:

> Currently org-agenda-bulk-action is completely broken if anything tries to
> take a log note during the action, this patch fixes it by storing log note
> setup variables in a list, and then taking one log note, and duplicating it
> over all affected items.

Thanks for the patch!

I tried to test the patch and ran into an issue using the following
recipe:

1. Create /tmp/bug.org with the following contents:

#+TODO: TODO(t) | DONE(d@)
* TODO this is test
* TODO this is test
* TODO this is test
* TODO this is test
* TODO this is test
* TODO this is test
* TODO this is test
* TODO this is test

2. Open Emacs from Org git repo folder containing the patch applied onto
   the latest main branch:
   make clean; make autoloads; emacs-29-vcs -Q -L ./lisp /tmp/bug.org

3. Open agenda via M-x org-agenda <RET> < t
4. Move point to one of the TODO entries and change the toto state to
   DONE: t DONE <RET>
5. The log window will pop. Enter "something" C-c C-c
6. Mark several TODO entries in the agenda
7. Try to bulk-mark them DONE: B t DONE <RET>
8. Observe no window popup, empty notes, and some entries not
   being marked as done in the agenda buffer.

Best,
Ihor