Re: [PATCH] org-test: Run all ol tests on make test

[Ihor Radchenko]

Max Nikulin <manikulin@gmail.com> writes:

> Hi,
>
> I figured out why "make test" is passing successfully while the same 
> with BTEST_RE="test-ol/insert-link-insert-description" is failing for a 
> proposed patch. Default selection pattern is ignoring most test-ol 
> cases. See the attachment.

Thanks a lot for narrowing this down!

> --- a/testing/org-test.el
> +++ b/testing/org-test.el
> @@ -424,7 +424,7 @@ setting `pp-escape-newlines' to nil manually."
>      "^\\([^.]\\|\\.\\([^.]\\|\\..\\)\\).*\\.org$")))
>  
>  (defun org-test-run-batch-tests (&optional org-test-selector)
> -  "Run all tests matching an optional regex which defaults to 
> \"\\(org\\|ob\\)\".
> +  "Run all tests matching an optional regex which defaults to 
> \"\\(org\\|ob\\|-ol\\)\".
>  Load all test files first."
>    (interactive)
>    (let ((org-id-track-globally t)

You missed the

        (org-test-selector
         (if org-test-selector org-test-selector "\\(org\\|ob\\)"))

inside org-test-run-batch-tests

Also, org-test-run-all-tests

Best,
Ihor