[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2-v2] New: auto display inline images under subtree when `org
From: |
Christopher M. Miles |
Subject: |
Re: [PATCH 2-v2] New: auto display inline images under subtree when `org-cycle'. |
Date: |
Fri, 30 Sep 2022 16:27:24 +0800 |
User-agent: |
mu4e 1.8.9; emacs 29.0.50 |
Ihor Radchenko <yantar92@gmail.com> writes:
> "Christopher M. Miles" <numbchild@gmail.com> writes:
>
>> Ihor Radchenko <yantar92@gmail.com> writes:
>>
>> I got a new problem in patch, the (point-max) in function
>> ~org-cycle-display-inline-images~ SOMETIMES return EOF error instead of
>> correct max point value when org-cycle `state' is ~'folded~. I can't
>> find out what caused this even using Edebug. Do you have any clue?
>
> Maybe because the 'folded branch in that function is not wrapped into
> `save-restriction'?
>
Ah, Indeed, I forgot to wrap it. Now I fixed this error.
I attached new version patch.
0001-org.el-Support-auto-display-inline-images-when-cycli.patch
Description: Text Data
>>> You are providing both hook and a customization. It is redundant. Users
>>> can already remove the hook when desired.
>>
>> I mock this style from a very similar existing hook function
>> ~org-cycle-hide-archived-subtrees~ and custom variable
>> ~org-cycle-open-archived-trees~. I think removing a hook function from
>> ~org-cycle-hook~ is a way, but not as convenient as defcustom option.
>> (P.S: I think users prefer this defcustom customization style.)
>
> I see your point.
> I agree that having a variable is better and also leaves an option to
> introduce in-buffer setting for this.
>
> Let's leave the hook part for now - if we want to alter it, we may need
> to re-consider all the default hooks.
Thanks
--
[ stardiviner ]
I try to make every word tell the meaning that I want to express without
misunderstanding.
Blog: https://stardiviner.github.io/
IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
signature.asc
Description: PGP signature
- Re: [PATCH 4] New: auto display inline images under subtree when `org-cycle'., (continued)
- Message not available
- Re: [PATCH 4] New: auto display inline images under subtree when `org-cycle'., Ihor Radchenko, 2022/09/15
- [PATCH 5] New: auto display inline images under subtree when `org-cycle'., Christopher M. Miles, 2022/09/15
- Message not available
- [PATCH v6] Re: [PATCH 5] New: auto display inline images under subtree when `org-cycle'., Ihor Radchenko, 2022/09/20
- Re: [PATCH v6] New: auto display inline images under subtree when `org-cycle'., Christopher M. Miles, 2022/09/20
- Message not available
- Re: [PATCH v6] New: auto display inline images under subtree when `org-cycle'., Ihor Radchenko, 2022/09/21
- [PATCH 2-v1] New: auto display inline images under subtree when `org-cycle'., Christopher M. Miles, 2022/09/28
- Message not available
- Re: [PATCH 2-v1] New: auto display inline images under subtree when `org-cycle'., Ihor Radchenko, 2022/09/28
- Re: [PATCH 2-v1] New: auto display inline images under subtree when `org-cycle'., Christopher M. Miles, 2022/09/29
- Re: [PATCH 2-v1 (test v1)] New: auto display inline images under subtree when `org-cycle'., Christopher M. Miles, 2022/09/29
- Message not available
- Re: [PATCH 2-v1] New: auto display inline images under subtree when `org-cycle'., Ihor Radchenko, 2022/09/29
- Re: [PATCH 2-v2] New: auto display inline images under subtree when `org-cycle'.,
Christopher M. Miles <=
- Message not available
- Re: [PATCH 2-v2] New: auto display inline images under subtree when `org-cycle'., Ihor Radchenko, 2022/09/30
- Message not available
- [ISSUE] Re: [PATCH] New: auto display inline images under subtree when `org-cycle'., Christopher M. Miles, 2022/09/12