[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] lisp/org-agenda.el: Fix filter preset problem for sticky age
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] lisp/org-agenda.el: Fix filter preset problem for sticky agenda |
Date: |
Wed, 05 Oct 2022 10:48:00 +0800 |
Liu Hui <liuhui1610@gmail.com> writes:
> I have signed the FSF
> copyright assignment paper.
Bastien, could you please confirm the FSF records?
> This patch fixes the bug originally reported in
> https://list.orgmode.org/59e02fb6.1462370a.fffe8.51c4@mx.google.com/
> with the following reproducing recipe. The bug still exists in latest
> org-mode.
> ...
>
> Because the filter presets are stored as symbol properties, they
> cannot be used with multiple sticky agenda buffers. The patch fixes
> the problem by adding a new variable `org-agenda-filters-preset' for
> getting and setting per-buffer filter presets. I have signed the FSF
> copyright assignment paper.
Thanks a lot for the contribution!
> Subject: [PATCH] lisp/org-agenda.el: Fix filter preset problem for sticky
> agenda
The patch is generally good. I just have one minor comment and one
suggestion.
> +(defvar org-agenda-filters-preset nil
> + "Preset of filters, which becomes buffer-local in org-agenda buffers.")
Can you detail the value format in the docstring?
It would also be useful to mention `org-agenda-local-vars'. Otherwise,
the reader might be confused how `defvar' is buffer-local.
Also, may you create a test for the reported bug in
testing/lisp/test-org-agenda.el?
--
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92