[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add 'backend' header arg to clojure code blocks
From: |
Ihor Radchenko |
Subject: |
Re: Add 'backend' header arg to clojure code blocks |
Date: |
Sun, 09 Oct 2022 15:42:52 +0800 |
Chris Clark <cfclrk@gmail.com> writes:
> This is my first attempt to contribute to org-mode; please let me know if
> I'm doing something wrong.
Thanks a lot! Contributions are always welcome.
Please also add a mention and/or example to the ob-clojure documentation
https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-clojure.html
(The source repository is https://git.sr.ht/~bzg/worg )
Also, you need to add an etc/ORG-NEWS entry about the new header
argument.
And I have few minor comments on the patch itself.
> From cc72dcac3075be76e3edcfee75c887272e48698c Mon Sep 17 00:00:00 2001
> From: Chris Clark <cfclrk@gmail.com>
> Date: Sat, 8 Oct 2022 05:41:20 -0400
> Subject: [PATCH] ob-clojure.el: Add a 'backend' header arg to clojure code
> blocks
^:backend
> * ob-clojure.el (org-babel-header-args:clojure,
> org-babel-execute:clojure): Add a 'backend' header arg that can
^:backend
> override the configured `org-babel-clojure-backend`.
^'
(by convention, we quote like `symbol' using `' pair).
Also, unless you have FSF copyright assignment, we need you to add
TINYCHANGE at the end of the commit message. See
https://orgmode.org/worg/org-contribute.html#first-patch
> + (t (user-error "You need to customize
> org-babel-clojure-backend")))))
While we are here, can as well quote `org-babel-clojure-backend'.
Or may even add "or set `:backend' header argument".
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- Add 'backend' header arg to clojure code blocks, Chris Clark, 2022/10/08
- Re: Add 'backend' header arg to clojure code blocks, Christopher M. Miles, 2022/10/08
- Re: Add 'backend' header arg to clojure code blocks,
Ihor Radchenko <=
- Re: Add 'backend' header arg to clojure code blocks, Chris Clark, 2022/10/09
- Re: Add 'backend' header arg to clojure code blocks, Ihor Radchenko, 2022/10/10
- [PATCH] Fix void variable error `cider-buffer-ns` when specifying :backend header argument, Christopher M. Miles, 2022/10/11
- Message not available
- Re: [PATCH] Fix void variable error `cider-buffer-ns` when specifying :backend header argument, Ihor Radchenko, 2022/10/12
- Re: [PATCH] (v2) Fix void variable error `cider-buffer-ns` when specifying :backend header argument, Christopher M. Miles, 2022/10/12
- Message not available
- Re: [PATCH] (v2) Fix void variable error `cider-buffer-ns` when specifying :backend header argument, Ihor Radchenko, 2022/10/12