[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Re: Update Org to MathJax 3
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] Re: Update Org to MathJax 3 |
Date: |
Sat, 05 Nov 2022 12:01:24 +0000 |
Rudolf Adamkovič <salutis@me.com> writes:
> Rudolf Adamkovič <salutis@me.com> writes:
>
>> I will resurrect the thread when I have something to show.
>
> All right, I have finished the second version of the patch.
Thanks!
> What do you think?
Your tests are failing on my side...
Also,
In org-html--build-mathjax-config:
ox-html.el:1999:40: Warning: malformed cond form: ‘nil’
I'll wait for a new version of the patch with tests passing before I do
a more elaborate review.
Some quick comments below.
> ox-html/mathjax-legacy-line-breaks-message-in-buffer): Test MathJax.
You forgot changelog entries for ORG-NEWS.
Also, you did not update the relevant manual sections.
> Reported-by: Rudolf Adamkovič <salutis@me.com>
There is no need to add Reported-by here. It is not a bug.
> +*** HTML export uses MathJax 3+ instead of MathJax 2
> +
> +Org 9.6 uses MathJax 3, a ground-up rewrite of MathJax 2 released
> +in 2019. The new version brings modularity, better and faster
> +rendering, improved LaTeX support, and more.
> +
> +For more information about new features, see:
> +
> +https://docs.mathjax.org/en/latest/upgrading/whats-new-3.0.html
> +https://docs.mathjax.org/en/latest/upgrading/whats-new-3.1.html
> +https://docs.mathjax.org/en/latest/upgrading/whats-new-3.2.html
This paragraph would look better at the end, after you discuss specific
features.
> +
> +See the updated =org-html-mathjax-options= for more details.
Please use code markup for symbols: ~org-html-mathjax-options~.
> (defcustom org-html-mathjax-options
> - '((path
> "https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.0/MathJax.js?config=TeX-AMS_HTML"
> )
> - (scale "100")
> + '((path "https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js")
> + (scale 1.0)
It will be worth mentioning that we change the JS provider.
People at least need to take note about different privacy policy.
> + (when value
> + (pcase symbol
> + ('font
It is recommended to use backquote `font in favor of direct quote 'font.
> + (when-let
> + ((new-value (cond
> + ((string= value "TeX")
> + "mathjax-tex")
> + ((string= value "STIX-Web")
> + "mathjax-stix2")
> + ((string= value "Asana-Math")
> + "mathjax-asana")
> + ((string= value "Neo-Euler")
> + "mathjax-euler")
> + ((string= value "Gyre-Pagella")
> + "mathjax-pagella")
> + ((string= value "Gyre-Termes")
> + "mathjax-termes")
> + ((string= value "Latin-Modern")
> + "mathjax-modern")
> + nil)))
Why not pcase?
> + (setq value new-value)))
> + ('linebreaks
> + (message "Converting legacy MathJax option: linebreaks")
Maybe warning?
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- [PATCH] Re: Update Org to MathJax 3, Rudolf Adamkovič, 2022/11/04
- Re: [PATCH] Re: Update Org to MathJax 3,
Ihor Radchenko <=
- Re: [PATCH] Re: Update Org to MathJax 3, Rudolf Adamkovič, 2022/11/05
- Re: [PATCH] Re: Update Org to MathJax 3, Rudolf Adamkovič, 2022/11/05
- Re: [PATCH] Re: Update Org to MathJax 3, Ihor Radchenko, 2022/11/05
- Re: [PATCH] Re: Update Org to MathJax 3, Rudolf Adamkovič, 2022/11/06
- Re: [PATCH] Re: Update Org to MathJax 3, Ihor Radchenko, 2022/11/06
- Re: [PATCH] Re: Update Org to MathJax 3, Rudolf Adamkovič, 2022/11/07
- Re: [PATCH] Re: Update Org to MathJax 3, Ihor Radchenko, 2022/11/08
- Re: [PATCH] Re: Update Org to MathJax 3, Rudolf Adamkovič, 2022/11/08
- Re: [PATCH] Re: Update Org to MathJax 3, Rudolf Adamkovič, 2022/11/08
- Re: [PATCH] Re: Update Org to MathJax 3, Ihor Radchenko, 2022/11/09