[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] org-attach.el: ID to path functions may return nil
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH v2] org-attach.el: ID to path functions may return nil |
Date: |
Wed, 16 Nov 2022 01:54:38 +0000 |
Max Nikulin <manikulin@gmail.com> writes:
>>> Please, remove a stray space in the defcustom.
>>
>> Hmm. Done.
>>
>> I just have a habit to add space in the first item in a list because it
>> helps auto-indentation.
>
> I had an impression that something was wrong with indentation of next
> entries.
I thought that you referred to '(<space>symbol ...
Other stray spaces were there because I forgot to disable nameless-mode.
> Sorry, but "important" entry should be before
> `org-attach-id-uuid-folder-format'. My idea is the following:
> - If the ID was generated by 'uuid or 'org `org-id-method' then prefer
> XX/... subfolder. It is important for new attachments. Even if current
> `org-id-method' is 'ts then this entry is ignored and layout is
> determined by the next entry.
> - If the ID is timestamp-based then prefer "YYYYMM/DDTIME" subfolder.
> - Put new non-standard IDs to important/X/... subfolder whenever
> particular ID is a short or a long one.
> - Handle the case of `org-id-method' changed in the past from timestamp
> to UUID or vice versa. Try to find attachment trying to split 2
> characters from timestamp or 6 characters from UUID. So add bare
> `org-attach-id-uuid-folder-format' and `org-attach-id-ts-folder-format'.
> These 2 entries may be skipped for new users or for users who never
> experienced change of `org-id-method'.
Agree.
I now applied the updated version of the patch.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=08a8c9e67
>>>> I also added the dumb fallback to the default value.
>>>> I feel that otherwise the description of too confusing.
>>>
>>> I am unsure concerning adding it to the default value. From my point of
>>> view, it is better to ask user to clarify their intention.
>
>> Handling too short IDs is a different issue indeed, but why not to fix
>> it as well?
>
> I still have a different opinion, but it should not prevent you from
> committing your variant. The issue is not critical.
>
> The problem is not too short ID. Actually they are some ID having
> unknown format, so functions designed for particular ID generation
> methods may cause a mess in attachment subdirs.
>>> If strict variants of functions were used above then non-standard IDs
>>> would be isolated in the directory returned by the next entry
>>
>> Good point.
>> What about using the value you provided in the NEWS as an actual default?
>
> It may be done by a next patch unless other issues will attract more
> attention.
I guess it does not heart to wait a bit. Though I do not see any issue
with updating the defaults to your version.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- [PATCH] org-attach.el: ID to path functions may return nil, Max Nikulin, 2022/11/07
- Re: [PATCH] org-attach.el: ID to path functions may return nil, Ihor Radchenko, 2022/11/08
- Re: [PATCH v2] org-attach.el: ID to path functions may return nil, Max Nikulin, 2022/11/09
- Re: [PATCH v2] org-attach.el: ID to path functions may return nil, Ihor Radchenko, 2022/11/10
- Re: [PATCH v2] org-attach.el: ID to path functions may return nil, Max Nikulin, 2022/11/13
- Re: [PATCH v2] org-attach.el: ID to path functions may return nil, Ihor Radchenko, 2022/11/14
- Re: [PATCH v2] org-attach.el: ID to path functions may return nil, Max Nikulin, 2022/11/14
- Re: [PATCH v2] org-attach.el: ID to path functions may return nil, Ihor Radchenko, 2022/11/14
- Re: [PATCH v2] org-attach.el: ID to path functions may return nil, Max Nikulin, 2022/11/15
- Re: [PATCH v2] org-attach.el: ID to path functions may return nil,
Ihor Radchenko <=