[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Explain how to end a buffer narrowing.
|
From: |
yuvallangerontheroad |
|
Subject: |
Re: [PATCH] Explain how to end a buffer narrowing. |
|
Date: |
Tue, 29 Nov 2022 18:20:24 +0000 |
On Saturday, November 26th, 2022 at 04:26, Ihor Radchenko <yantar92@posteo.net>
wrote:
> yuvallangerontheroad yuvallangerontheroad@proton.me writes:
>
> > > Extra [...] are redundant.
> > > Please test the patch before submitting.
> >
> > Sorry. Removed redundant brackets.
>
>
> Thanks.
:)
> It is also a good idea to add quotes around the command key. See the
> example in 25.3 Substituting Key Bindings in Documentation
> (I am honestly not sure how important quoting is, but let's better
> follow the Elisp manual).
Hopefully done.
> Also, please make the commit message more concrete.
>
> Maybe something like
>
> org: Mention how to widen in docstrings of the commands that do narrowing
Hopefully done.
> Finally, please follow the commit message format as described in
> https://orgmode.org/worg/org-contribute.html#commit-messages
> In particular, add the changelog entries and TINYCHANGE cookie (I assume
> that you don't have FSF copyright assignment).
Hopefully done.
Please review.
0001-lisp-org.el-Mention-how-to-widen-in-docstrings-of-co.patch
Description: Text Data