[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] ob-eval: display error fix
From: |
Andreas Gerler |
Subject: |
Re: [O] [PATCH] ob-eval: display error fix |
Date: |
Sun, 8 Jan 2023 12:16:54 +0100 |
0001-lisp-ob-eval.el-Display-error-fix.patch
Description: Binary data
Hi Ruijie,
thanks for asking.
I combined them now and tested again all variants.
Andreas
> On 7. Jan 2023, at 22:33, Ruijie Yu via General discussions about Org-mode.
> <emacs-orgmode@gnu.org> wrote:
>
>
> Hi Andreas,
>
> - (display-buffer buf))
> + (if org-babel-eval-error-display-notify
> + (display-buffer buf)
> + (if (or (not (numberp exit-code))
> + (> exit-code 0))
> + (display-buffer buf))))
>
> Quick question, does it help or hurt readability if we change this
> nested `if' into a `cond' expression?
>
> Or, alternatively, since both the outer then branch and the inner then
> branch are the same expression, maybe we can just combine all three
> conditions into a single `or' call?
>
> Something like
>
> (when (or org-babel-eval-error-display-notify
> (not (numberp exit-code))
> (> exit-code 0))
> (display-buffer buf))
>
> Best,
>
>
> RY
>
signature.asc
Description: Message signed with OpenPGP