[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ob-sql: Add support for Athena
From: |
Tim Cross |
Subject: |
Re: [PATCH] ob-sql: Add support for Athena |
Date: |
Tue, 17 Jan 2023 07:50:45 +1100 |
User-agent: |
mu4e 1.9.14; emacs 29.0.60 |
Ihor Radchenko <yantar92@posteo.net> writes:
> Daniel Kraus <daniel@kraus.my> writes:
>
>> I'm using this patch since a few month that adds support
>> for AWS Athena.
>> The only thing that's maybe against adding it is that
>> `athenacli` (https://github.com/dbcli/athenacli) is not an
>> official AWS tool but just a Python script.
>>
>> What's the opinion on this?
>
> Is this something commonly used?
>
> I see two main issues with the idea:
> 1. I do not like the idea of adding all the possible CLI tools over
> there in ad-hoc manner. It would be cleaner to provide a
> customization to add various cli tools in a defcustom/defvar without
> manually changing the functions.
>
> 2. I feel like it will be hard to maintain such unpopular clients. If
> (1) is addressed + good automatic tests are implemented, things may
> be acceptable for inclusion though.
>
> In summary, I am not against the idea of including a new sql cli, but we
> should better provide a centralized API to do so and make sure that we
> have test coverage, making sure that things are not broken in future,
> when the original committer is gone and nobody else is left familiar
> with specific obscure SQL client.
I think you run a high risk of running into GNU policy issues wrt
licensing and free software support given this is a cleint for an AWS
only database.
- [PATCH] ob-sql: Add support for Athena, Daniel Kraus, 2023/01/16
- Re: [PATCH] ob-sql: Add support for Athena, Ihor Radchenko, 2023/01/16
- Re: [PATCH] ob-sql: Add support for Athena, Daniel Kraus, 2023/01/16
- Re: [PATCH] ob-sql: Add support for Athena,
Tim Cross <=
- Re: [PATCH] ob-sql: Add support for Athena, Daniel Kraus, 2023/01/17
- Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena), Ihor Radchenko, 2023/01/17
- Re: Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena), Tim Cross, 2023/01/17
- Re: Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena), Richard Stallman, 2023/01/22
- Re: Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena), Jean Louis, 2023/01/23
- Re: Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena), Richard Stallman, 2023/01/24
- Re: Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena), Tim Cross, 2023/01/25
- Re: Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena), Ihor Radchenko, 2023/01/25
- Re: Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena), Tim Cross, 2023/01/25
- Re: Supporting non-free SQL clients in ob-sql (was: [PATCH] ob-sql: Add support for Athena), Ihor Radchenko, 2023/01/25