Re: [PATCH] Fix some emacs-30 byte-compile warnings

[Robert Pluim]

>>>>> On Mon, 23 Jan 2023 14:04:42 +0000, Ihor Radchenko <yantar92@posteo.net> 
>>>>> said:

    Ihor> Robert Pluim <rpluim@gmail.com> writes:
    >> The emacs 30 byte-compiler warns about uses of `eq'
    >> and similar with constant strings which might have unintended
    >> semantics. Patch is against emacs master.

    Ihor> Thanks, but it will break some tests:

    Ihor> 3 unexpected results:
    Ihor>    FAILED  test-org-table/copy-field
    Ihor>    FAILED  test-org-table/references/mode-string-N
    Ihor>    FAILED  test-org-table/references/mode-string-none

Hmm, at least the first one is because the code in the 't' branch of
            (if (and (eq elements "") (not keep-empty))

in org-table-make-reference now runs, and it results in

(eval '(identity))'

Of course fixing that causes other problems <sigh>

Iʼll get back to this maybe tomorrow.

Robert
--