[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Async evaluation in ob-shell
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] Async evaluation in ob-shell |
Date: |
Sat, 11 Feb 2023 11:44:56 +0000 |
Matt <matt@excalamus.com> writes:
> It seems to me like 02-ob-shell-async-non-file.patch is all that's needed for
> basic async in ob-shell. I'm able to run long processes like `guix pull' and
> `guix package -u' calls without issue and the results look like I expect.
> Similarly for running a web server, such as `python3 -m http.server' and
> killing it.
>
> Unless there's something you or others think needs to be done, I can get it
> committed (and try to write a test or two for it).
1. You should provide all the docstrings.
2. I generally feel that separate async and separate session code are
either duplicating the same code or edge cases considered by session
code may popup in async code unexpectedly.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- [PATCH] Async evaluation in ob-shell, Matt, 2023/02/06
- Re: [PATCH] Async evaluation in ob-shell, Ihor Radchenko, 2023/02/07
- Re: [PATCH] Async evaluation in ob-shell, Matt, 2023/02/08
- Re: [PATCH] Async evaluation in ob-shell, Ihor Radchenko, 2023/02/09
- Re: [PATCH] Async evaluation in ob-shell, Matt, 2023/02/10
- Re: [PATCH] Async evaluation in ob-shell,
Ihor Radchenko <=
- Re: [PATCH] Async evaluation in ob-shell, Matt, 2023/02/12
- Re: [PATCH] Async evaluation in ob-shell, Ihor Radchenko, 2023/02/15
- Re: [PATCH] Async evaluation in ob-shell, Matt, 2023/02/15
- Re: [PATCH] Async evaluation in ob-shell, Ihor Radchenko, 2023/02/17
- Re: [PATCH] Async evaluation in ob-shell, Matt, 2023/02/19
- Re: [PATCH] Async evaluation in ob-shell, Ihor Radchenko, 2023/02/20
- Re: [PATCH] Async evaluation in ob-shell, Matt, 2023/02/20
- Re: [PATCH] Async evaluation in ob-shell, Ihor Radchenko, 2023/02/22
Re: [PATCH] Async evaluation in ob-shell, jackkamm, 2023/02/11