Re: [PATCH] Fix some emacs-30 byte-compile warnings

[Robert Pluim]

>>>>> On Fri, 17 Feb 2023 14:08:04 +0000, Ihor Radchenko <yantar92@posteo.net> 
>>>>> said:

    Ihor> Robert Pluim <rpluim@gmail.com> writes:
    Ihor> 3 unexpected results:
    Ihor> FAILED  test-org-table/copy-field
    Ihor> FAILED  test-org-table/references/mode-string-N
    Ihor> FAILED  test-org-table/references/mode-string-none
    >> 
    >> Hmm, at least the first one is because the code in the 't' branch of
    >> (if (and (eq elements "") (not keep-empty))
    >> 
    >> in org-table-make-reference now runs, and it results in
    >> 
    >> (eval '(identity))'
    >> 
    >> Of course fixing that causes other problems <sigh>

    Ihor> Meanwhile, I fixed all the other warnings.
    Ihor> 
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eea8da0315b4d9c43272f4ee87d752e651f1a0c0
    Ihor> Now, only this org-table problem remains.

    Ihor> It is clearly a bug of some kind - the code is not doing what it
    Ihor> intended originally. But we need to understand org-table.el better to
    Ihor> fix this...

Iʼve not had time to look at it further (probably my subconscious not
wanting to deal with org-table.el :-))

Robert
--