|
From: | Max Nikulin |
Subject: | Re: [PATCH] Fix ob-latex.el command injection vulnerability. |
Date: | Sat, 18 Feb 2023 18:15:48 +0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 |
On 18/02/2023 17:08, lux wrote:
- (shell-command (format "mv %s %s" img-out out-file))))) + (shell-command (format "mv %s %s" (shell-quote-argument img-out) (shell-quote-argument out-file))))))
Thank you for the patch. Certainly it is an improvement.Is there any reason why `rename-file' should be avoided here? I just have discovered this function, so I am unaware of possible pitfalls.
(info "(elisp) Changing-Files") https://www.gnu.org/software/emacs/manual/html_node/elisp/Changing-Files.html#index-rename_002dfile
[Prev in Thread] | Current Thread | [Next in Thread] |