[DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

[Ruijie Yu]

Ruijie Yu via "General discussions about Org-mode." <emacs-orgmode@gnu.org> 
writes:

> Ruijie Yu via "General discussions about Org-mode." <emacs-orgmode@gnu.org> 
> writes:
>
>> Ruijie Yu via "General discussions about Org-mode." <emacs-orgmode@gnu.org> 
>> writes:
>>
>>> Axel Kielhorn <org-mode@axelkielhorn.de> writes:
>>>
>>>> Hello!
>>>>
>>>> I’m building org with LANG=de.
>>>> As a result I get two failed tests:
>>>
>>> Reproducible using "LANG=zh_CN.UTF-8".  In fact, I got more failed tests
>>> in my testing.  I think the OP's two test failures are due to hardcoded
>>> English expected result, whereas the additional test failures on my
>>> testing are probably due to the fact that each Chinese character is as
>>> wide as two latin letters, which catches some testing code offguard.
>>>
>>> Here are the test names that failed unexpectedly for me.  All the
>>> "should"'s and "should-not"'s are in the attachment below.
>>>
>>> --8<---------------cut here---------------start------------->8---
>>> 8 unexpected results:
>>>    FAILED  test-org-clock/clock-drawer-dwim
>>>    FAILED  test-org-clock/clocktable/lang
>>>    FAILED  test-org-clok/org-clock-timestamps-change
>>>    FAILED  test-org-colview/columns-width
>>>    FAILED  test-org/add-planning-info
>>>    FAILED  test-org/clone-with-time-shift
>>>    FAILED  test-org/deadline
>>>    FAILED  test-org/schedule
>>> --8<---------------cut here---------------end--------------->8---
>>>
>>> [3. text/plain; lang.txt]...
>>
>> Update: interestingly, there is one test error when setting
>> "LANG=en_US.UTF-8" or "LANG=C".
>>
>> [2. text/plain; lang-en-us-utf8.txt]...
>>
>>
>> And, two somewhat different test errors when setting "LANG=fr_FR.UTF-8".
>>
>> [4. text/plain; lang-fr-fr-utf8.txt]...
>
> Axel, does this patch fix test-org-clock/clock-drawer-dwim on your
> system?
>
> [2. text/x-patch; 0001-testing-lisp-test-org-clock.el.patch]...

Here is an updated patch (replacing the first iteration).  This should
hopefully fix both test failures that Axel found.  Once this is
confirmed good, I will look at the test failures of the other languages
to see what I can do.

0001-DRAFT-Fix-dependence-on-locale-in-org-testing-facili.patch
Description: Text Data

-- 
Best,


RY

[Please note that this mail might go to spam due to some
misconfiguration in my mail server -- still investigating.]