Re: [PATCH] Add tests for ob-haskell (GHCi)

[Bruno Barbier]

Ruijie Yu <ruijie@netyu.xyz> writes:

> Minor remarks below regarding the patchset.
>
> Bruno Barbier <brubar.cs@gmail.com> writes:
>
>> +;; Copyright (c) 2023  Free Software Foundation, Inc.
>
> lisp/org.el has only a single space, so probably single space here as well.

Done.

>> +
>> +;; Authors: Bruno BARBIER <brubar.cs@gmail.com>
>> +
>> +;; This program is free software; you can redistribute it and/or modify
>> +;; it under the terms of the GNU General Public License as published by
>> +;; the Free Software Foundation, either version 3 of the License, or
>> +;; (at your option) any later version.
>
> Do we need the text for "part of GNU Emacs"?
>

I guess it doesn't harm: I added it, thanks.


>> +
>> +(defun test-ob-haskell-ghci--with-global-session-worker (todo)
>> +  "See `test-ob-haskell-ghci--with-global-session-worker'."
>
> This docstring doesn't say much and only refers to itself.  Maybe
> explain what it does?  (Or now that I look at it, potentially you wanted
> to refer to the macro `test-ob-haskell-ghci-with-global-session'
> instead.)

I've rewritten that function later ... which made the documentation even worse 
:-)
I've fixed it, thanks.


>
>> +(defun test-ob-haskell-ghci (args content &optional preamble unprotected)
>> +  "Execute the code block CONTENT in a new GHCi session; return the result.
>> +Add ARGS to the code block argument line.  Insert PREAMBLE
>> +before the code block.  When UNPROTECTED is non-nil, don't control
>> +which session is used (i.e. don't call
>> +`test-ob-haskell-ghci--with-global-session-worker')."
>> +  (when (listp content)
>> +    (setq content (string-join content "\n")))
>> +  (unless preamble
>> +    (setq preamble ""))
>> +  (let ((todo  (lambda ()
>
> One space.

AFAICS, the last version has only one space here.


>> +
>> +;;;; Not define  errors
>> +;;

> Single space?

It was an invisible 'd' actually; I repainted in black :-)
Thanks.


Thank you for your review,

Bruno

0001-ob-haskell-Add-tests-for-GHCi.patch
Description: Text Data

0002-org-babel-haskell-initiate-session-Remove-secondary-.patch
Description: Text Data

0003-testing-lisp-test-ob-haskell-ghci.el-Fix-some-tests.patch
Description: Text Data

0004-testing-lisp-test-ob-haskell-ghci.el-Enable-fixed-te.patch
Description: Text Data

0005-lisp-ob-haskell-Request-the-last-value-from-GHCi.patch
Description: Text Data

0006-ob-haskell-Implement-sessions.patch
Description: Text Data

0007-ob-haskell-Update-tests-about-errors.patch
Description: Text Data

0008-testing-lisp-test-ob-haskell-ghci.el-Cleanup-comment.patch
Description: Text Data

0009-lisp-ob-haskell.el-Simplify-org-babel-haskell-eoe.patch
Description: Text Data

0010-testing-lisp-test-ob-haskell-ghci.el-Test-output-wit.patch
Description: Text Data

0011-lisp-ob-haskell.el-Fix-how-to-use-sessions.patch
Description: Text Data

0012-testing-lisp-test-ob-haskell-ghci.el-Modify-test-ob-.patch
Description: Text Data

0013-testing-lisp-test-ob-haskell-ghci.el-Update-session-.patch
Description: Text Data