emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Org mode version 9.7-pre (9.7-pre-n/a-g63e8ca @ /home/n/.emacs.d/elp


From: Ihor Radchenko
Subject: Re: Org mode version 9.7-pre (9.7-pre-n/a-g63e8ca @ /home/n/.emacs.d/elpaca/builds/org/); [PATCH] refactor org-babel-lilypond-compile-lilyfile
Date: Mon, 04 Sep 2023 07:47:03 +0000

No Wayman <iarchivedmywholelife@gmail.com> writes:

> Ihor Radchenko <yantar92@posteo.net> writes:
>
>>> - Removes the optional TEST parameter, which is unused and 
>>> better 
>>>   served through debugging tools.  
>>
>> This is technically a breaking change. So, we (1) need to 
>> mention it in
>> ORG-NEWS; (2) may consider (file-name &optional _) function 
>> definition
>> to be 100% sure that no existing code will be broken.
>
> I've added the NEWS entry and updated the signature to ignore the 
> second, optional parameter.
> See attached.

Thanks!

> +*** ~org-babel-lilypond-compile-lilyfile~ ignores optional second argument
> +
> +The =TEST= parameter is better served by Emacs debugging tools.

It looks like ob-lilypond/ly-compile-lilyfile test is relying on this
optional second argument. So, after applying your patch, make test is
failing.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]