emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [FR] Should we preserve point when calling `org-open-at-point' (C-c


From: Ihor Radchenko
Subject: Re: [FR] Should we preserve point when calling `org-open-at-point' (C-c C-o) on a heading (was: [BUG] Point position with org-open-at-point on a heading [9.6.6 (release_9.6.6 @ /usr/local/share/emacs/29.1/lisp/org/)])
Date: Mon, 23 Oct 2023 11:32:49 +0000

Ihor Radchenko <yantar92@posteo.net> writes:

>>>> Perhaps there's some reason why
>>>> point is not preserved in this case. But for me at least, this is not
>>>> what I'd expect, and I find it somewhat disrupting, especially when
>>>> I'm working on a folded tree (defeats speed keys, etc.).
>>> 
>>> I see no particular reason.
>>
>> Maybe the following is a false alarm. I hope `save-excursion' will not 
>> break the "RET to open all" option, `org-open-at-point' is called 
>> recursively this case.
>
> "Open all" is broken now.
>
> That said, your concern is valid - if we open internal link, it will be
> expected the point jumps to that link rather than staying on the
> heading.

I believe that I now addressed all the concerns:
1. Point position is not preserved by default.
2. When a link being open moved point in current buffer, we do allow
   changing the position.
3. When multiple links are open, things should not be broken.
4. When multiple links are open and some of them (more than 1) also move
   point, we move point to the position defined by the last of such
   links.

Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=098f08159

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]