Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items

[Ihor Radchenko]

Anders Johansson <mejlaandersj@gmail.com> writes:

> Included is a patch for the filtering (I assumed cl-intersection was
> reasonable to use since cl-lib is a requirement).
>
> However, I do not think this is enough, since it can cause quite
> unexpected results when canonical is used without specifying the
> format, Hence, I do think the previous patch should also be applied.
>
> For my case, org-duration-format is (("m") ("w") ("d") (special . h:mm)).
> This call to org-duration-from-minutes (like in org-agenda-format-item):
>
> (org-duration-from-minutes MINUTES nil t)
>
> will then result in a full format amounting to (("d")), (since
> "special" is not part of the canonical units), which is hardly what is
> expected for the agenda.

The patch breaks tests and thus cannot be applied.

May you please provide more details about the original problem you were
trying to solve? Preferably with a reproducer.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>