emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] org-babel-demarcate-block: split using element API


From: gerard . vermeulen
Subject: Re: [PATCH] org-babel-demarcate-block: split using element API
Date: Mon, 19 Feb 2024 13:01:28 +0000



On 19.02.2024 10:46, Ihor Radchenko wrote:
Ihor Radchenko <yantar92@posteo.net> writes:

gerard.vermeulen@posteo.net writes:

I think that I have improved my region marking code by using "<point>"
in the temp-text as a start. Then, I only have to find where to set
mark,
and eventually exchange point and mark.

Still failing on my side (when running tests non-interactively from
command line). To fix the problem, please use the approach from
`test-org-list/indent-item':

            (transient-mark-mode 1)
            (push-mark (point) t t)

Instead of (set-mark-command nil)

Gerard, may I know if you had a chance to look into my comments?

I think that I have addressed this particular comment.

However, I am confused by your comments concerning this example
#+begin_src emacs-lisp
  <mark>'(1 2 3)
  '(1 2 <point>3)
#+end_src
since it breaks my patch as well as main in the sense that such examples
can generate three blocks with invalid code.
I think there is in general no way to protect a user against bad selections
for splitting by demarcation.

Secondly, I see (saw) sometimes Org emitting warnings with backtraces
starting from my patch. I think the warning may be due either to a mistake
on my side or a bug in Org, but I am not sure.

Regards -- Gerard







reply via email to

[Prev in Thread] Current Thread [Next in Thread]