[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name |
Date: |
Sat, 16 Mar 2024 10:11:38 +0000 |
Matt <matt@excalamus.com> writes:
> Finally had time to commit it.
>
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0e2a9524dc6da8b4d60672e85aba74076baac211
Thanks!
I notice that you changed the commit author and only referenced Aaron in
Submitted By: metadata.
For future, we prefer keeping the original commit author in the "author"
field of the commits - this is important to keep track of the number of
changed lines for contributors without FSF copyright assignment.
You may consider using https://git.kyleam.com/piem/about/ to apply
patches submitted as emails automatically. Or you can assign the commit
author manually, using -A git commit switch (magit also provides a
transient menu option for this).
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name, Aaron L. Zeng, 2024/03/11
- Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name, Matt, 2024/03/11
- Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name, Ihor Radchenko, 2024/03/12
- Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name, Matt, 2024/03/15
- Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name, Aaron Zeng, 2024/03/15
- Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name,
Ihor Radchenko <=
- How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name), Matt, 2024/03/17
- Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name), Ihor Radchenko, 2024/03/17
- Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name), Matt, 2024/03/17
- Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name), Ihor Radchenko, 2024/03/17
- Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name), Max Nikulin, 2024/03/17
- Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name), Matt, 2024/03/17