emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Unit tests for function calling MathML converters (Re: Warn


From: Max Nikulin
Subject: Re: [PATCH] Unit tests for function calling MathML converters (Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command)
Date: Mon, 1 Apr 2024 17:39:04 +0700
User-agent: Mozilla Thunderbird

On 31/03/2024 15:27, Ihor Radchenko wrote:
Max Nikulin writes:

+(ert-deftest test-org/format-latex-as-html ()
+  "Test shell special characters escaping in `org-format-latex-as-html'."
+  (let ((org-latex-to-html-convert-command
+         "printf \"<I%%sI>\" %i"))

I have a concern about this test - it will not work on windows or in

I do not mind to add

   (skip-unless (not (memq system-type '(ms-dos windows-nt))))

non-standard system shells. We should probably disable the test unless
"printf" can be evaluated in the current system shell.

POSIX printf is more portable than "echo". Anyway Makefile expects a POSIX compatible shell. So I believe, it is developer responsibility to run build and test with a sane shell even if they prefer something unusual as the interactive shell.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]