emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ox-texinfo: Support links in headings


From: Ihor Radchenko
Subject: Re: [PATCH] ox-texinfo: Support links in headings
Date: Sun, 15 Sep 2024 12:37:30 +0000

Rudolf Adamkovič <rudolf@adamkovic.org> writes:

> From: Rudolf Adamkovic <rudolf@adamkovic.org>
>
> * etc/ORG-NEWS (Texinfo exporter now supports links in headings):
> Announce the new feature.
> * lisp/ox-texinfo.el: (org-texinfo--format-entries,
> org-texinfo--get-node, org-texinfo--sanitize-title-reference,
> org-texinfo--sanitize-title): A 2-step change: (1) Rename
> `--sanitize-title' to `--sanitize-title-reference' and (2) create a
> new `--sanitize-title' sanitation function.  The new function is less
> strict in that does not remove links, which should be allowed in
> sectioning commands, such as `@unnumbered'.  The old function remains
> more strict, which is useful for generating `@node' names, for
> example.
> * testing/lisp/test-ox-texinfo.el:
> (test-ox-texinfo/headings-with-links): Test the new functionality to
> avoid regressions in the future.

Thanks!

I tried to run make test and your new test fails:

Test test-ox-texinfo/headings-with-links condition:
    (search-failed "^@chapter Heading 2 (@ref{Heading 1})$")

May you please fix this and also rebase the patch onto the latest main?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]