emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: packages submissions : ob-sql-session and org-blog


From: Phil Estival
Subject: Re: packages submissions : ob-sql-session and org-blog
Date: Tue, 17 Sep 2024 12:00:57 +0200
User-agent: Mozilla Thunderbird


* [2024-09-11 05:01] Adam Porter:
Hi Phil,

A quick, initial suggestion: it would be good to reformat the Lisp code in both projects, as I see several cases of incorrect indentation, hanging parens, extra blank lines, etc, and some of them would make the code hard to read.  For my Lisp editing, I use aggressive-indent-mode, which ensures that the code is always indented correctly.  For some other reformatting, Oleh Krehel's Lispy package has commands to help.

Hi Adam,

Also, for org-sql-session (which sounds very useful), it would be good
to compare and contrast it with the package it's meant to supersede.

The following comparison was added to the readme file.

ob-sql-mode :
- is very simple : forward the sql source through `sql-redirect'
- has a test suite
- but gives clunky output
- no :results table
- sql client shell commands messes up output
- prompt again for connection parameters when restarting a session

ob-sql-session :
- handle large results
- has :results tables
- accept header variables (:var)
- accept sql client shell commands
- keep login parameters
- prompt only for blank connection parameters
- can use `with-environment-variables'
- provide some more tests

since it's meant to integrate with org-babel, it might be good to discuss its inclusion on the Org mailing list also.

CC-ing the Org mailing list.

Phil



reply via email to

[Prev in Thread] Current Thread [Next in Thread]