Re: [PATCH] Fix ox-icalendar export of diary timestamps

[Ihor Radchenko]

Jack Kamm <jackkamm@gmail.com> writes:

> ox-icalendar skips the following event with a diary timestamp during
> export:
>
>   * First Sunday of the month
>   <%%(diary-float t 0 1)>
>
> ox-icalendar actually has longstanding code to handle diary timestamps
> [1], but that code path is not reached, in part because
> `org-export--skip-p' always skips timestamps with type `diary'.
>
> The attached patch fixes this by including diary timestamps when the
> export option `:with-timestamps' is `active'. I think it's reasonable
> to consider diary timestamps as a type of active timestamp during
> export, since they are included in the agenda, and have angle
> brackets.

I agree that it makes sense.
However, it is technically a breaking change.
May you please add a news entry as well?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>