Re: [PATCH] org-protocol: Add void() to bookmarklets

[Ihor Radchenko]

Max Nikulin <manikulin@gmail.com> writes:

>> Another variant from reddit is
>> 
>> javascript:location.href='org-protocol://store-link?'+new 
>> URLSearchParams({url:location.href, title:document.title}); void(0);
>
> If you think that ";void(0)" variant is less prone to errors then I may 
> update my patch. I have no idea if balanced void(...) parenthesis around 
> the whole expressions would cause more user mistakes. Otherwise both 
> variants are equivalent.

Then, no need to change your variant.

>>> Should ORG-NEWS be updated as well?
>> 
>> Yes, I think. In announcement section.
>> This is one of the cases when we want people to consider changing their
>> usual configs.
>
> My idea is to fix existing examples in place, perhaps with a small 
> remark on update reason.

Sure.

> Maybe experienced users of bookmarklets are aware of the "void" trick 
> and provided examples were enough for them.

The news are aiming at non-experienced users in this case.

> I consider the change as a minor fix that does not deserves loud 
> announcement, especially taking into account that browsers discourages 
> protocol handlers launched on behalf of web pages nowadays.

It is indeed minor. However, ORG-NEWS is not about minor or major, but about
answering a question: "should some users update their configuration?" or
"should some users consider changing the existing workflow?".

In this case, it is a good idea for users of the previously suggested
bookmarklet to update to the new version. This way, they will be less
likely to meet breakage one day when they decide to upgrade Firefox.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>