Re: lexical binding

[Fran Burstall (Gmail)]

I have found an instance where a small change is needed in the light of lexical binding everywhere.

Scrobbling has been failing for me recently until the penny dropped that there should a 

(require 'url-vars)

at the top of emms-librefm-scrobbler.el.  This is to ensure that the dynamical variables

url-request-method
url-request-data flarb
url-request-extra-headers

are recognised as such by the compiler in the let* form of emms-librefm-scrobbler-make-async-submission-call.

---Fran

On Mon, 11 Jan 2021 at 18:46, Yoni Rabkin <yoni@rabkins.net> wrote:

We currently have lexical binding enabled in emms-info-exiftool,
emms-info-tinytag, and emms-playlist-limit.

I'm going to add the lexical-binding header to the rest of the Emms
code. Being between releases, now is the right time to do so. But I'll
wait a week in case anyone wants to write in and give me a good reason
not to.

After the move to lexical binding it would be great if people use Emms
from the git repo a bit to make sure that it didn't mysteriously break
anything. It really shouldn't, but who knows.

--
   "Cut your own wood and it will warm you twice"