emms-help
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fetching synchronized lyrics from LRCLIB


From: Daniel Semyonov
Subject: Re: Fetching synchronized lyrics from LRCLIB
Date: Fri, 29 Nov 2024 00:22:51 +0200
User-agent: Gnus/5.13 (Gnus v5.13)

>>>>> Yoni Rabkin writes:

    > Daniel Semyonov <daniel@dsemy.com> writes:
    >>>>>>> Yoni Rabkin writes:
    >> > Wouldn't it fail if Emacs is compiled without native json parsing
    >> > (--with-json)?
    >> 
    >> Oh sorry, I didn't think to test that, I'll do that when I get home.

    > There is nothing wrong with adding a feature to Emms which requires a
    > compile-time option, but we would need to make sure that the feature
    > deals with that option's absence gracefully.

No worries, I added (and tested) support for parsing without JSON if not
available; it's fairly simple to do in this case.
Also pushed a small fix to the documentation I added.

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]