[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: pvm.jitter patch for no-threading
From: |
Jose E. Marchesi |
Subject: |
Re: pvm.jitter patch for no-threading |
Date: |
Sat, 03 Apr 2021 19:13:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Luca.
> This is a *minimal* set of changes required to make no-threading work;
> the current code could become more efficient, but with these changes it
> is correct.
>
> As you can see the only required modifications are uses of the new
> attribute "branching", and some function/global wrappings. In the case
> of I/O instructions which are high-latency anyway, instead of worrying
> about wrapping globals, I have opted to make the instructions
> non-relocatable.
>
> This on my system gives zero test suite failures. You can check on my
> private branch lucasaiu/poke-no-threading .
The patch itself looks ok, but for:
- pk_term_class
- pk_term_end_class
- pk_printf
+# pk_term_class
+# pk_term_end_class
+# pk_printf
Why commenting these out instead of removing them?
Also, there are a few commented-out:
# non-relocatable
Do we need these?