Re: [fluid-dev] Re: Changes checked into CVS

[Paul Millar]

On Monday 11 December 2006 14:24, Josh Green wrote:
> On Mon, 2006-12-11 at 00:19 +0200, Mihail Zenkov wrote:
> > IMHO better replace roundf with this code in all case:
> >
> > inline int roundi(float x)
[..]
> > It slightly faster then gcc roundf (1.5 time).
>
> Sounds good, will also be more portable :)  I suppose a macro such as
> this would also do the trick?
>
> #define roundi(x)   ((x >= 0.0f) ? (int)(x+0.5f) : (int)(x-0.5f))

You'd need parentheses around the x characters in the expansion.  Even then, 
its slightly dangerous:

y = roundi( sin(x));

results in two evaluations of sin(x).  The quintessential bad one is:

y = roundi( x++);

}:->

Cheers,

Paul.

pgpQmVnprvYc4.pgp
Description: PGP signature