Re: [Freeipmi-devel] new freeipmi coding and freeipmi hostrange docs in CVS

[Levi Pearson]

On Fri, 2007-05-04 at 14:41 -0700, Al Chu wrote:
> just added two docs, comments are welcome:
> 
> doc/freeipmi-coding.txt - coding style intro, explanation of coding
> decisions done in libfreeipmi.

I like it so far, though it doesn't seem to address some of the issues
that you found in my initial patch submissions, such as sanity checking
of parameters for nulls and lengths.  I'm not sure if those are within
the intended scope of the document or not.

One question I've been meaning to ask is regarding tabs vs. spaces.
While trying to emulate the style of the surrounding code I was working
on, I noticed that sometimes tabs are expanded to spaces and sometimes
they're not.  Is there a standard for the project?

I also want to say that I really like the fiid structure and associated
macros and functions, though it took me a little while to figure them
out.  I'm a little sad that the scheme interpreter was deprecated and
removed, too. 

> 
> doc/freeipmi-hostrange.txt - describes using the new hostrange support
> in freeipmi.
> 

This looks very nice.  I'm going to have to look at it in more depth,
but it looks like another big step in cluster usability over ipmitool,
which we've been using.  I may have some more comments later after I get
a chance to play with the pdsh-like features.

                --Levi