Re: [pooma-dev] src/Particles/tests compilable

[Richard Guenther]

Roman Krylov wrote:
> Hi.
> Now all src/Particles/tests compilable.
>
> What I have to note especially is that I had commented
> //#include "Particles/InterpolatorNGP.h"
> //#include "Particles/InterpolatorCIC.h"
> //#include "Particles/InterpolatorSUDS.h"
> in src/Pooma/Particles.h - I think it'll be better if one who need it 
> will include it manually OK?
> And I've commented all 'setExternalGuards(field,zero);'. As I thought 
> external guards are only an optimization not real g.l. ?

They are real guard layers, but this use looked suspicious to me, too, 
as usually external guards filling is up to the user, as is the physical 
domain.  Maybe Julian can comment on this:

Interpolator<Dim,T,CIC>::scatter(const PA& attrib, const FC& field, 
const PPos& pos)
{
   ...
      // Zero out the guard layers before scattering
      typename FC::Element_t zero(0);
      field.engine().setGuards(zero);
      setExternalGuards(field,zero);
   ...
}

The question is, if we assume the destination field to be zeroed by the 
user at entry of this function, then we need to do this only if we 
bypass the guard updating.  And this will be an optimization, if and 
only if we assum initial zero field value (else clearing the internal 
guards is even wrong).  The external guards can be handled by the user
by just field.all() = 0.0; before scattering, instead of field = 0.0;

How was this all supposed to being used?

Richard.

> As I had noticed previously 'pointIndex'->'cellContaining'
> and also 'indexPoint'->'vertexPosition'.
> Well here they are(attached).
> Roman.