Re: [pooma-dev] [PATCH] Fix ExpressionTest

[Jeffrey D. Oldham]

Richard Guenther wrote:

> Richard Guenther wrote:
>
> > 2004Aug24  Richard Guenther <address@hidden>
> >
> >     * src/Engine/Stencil.h: do bounds check only with
> >     POOMA_BOUNDS_CHECK.
> >     src/Field/DiffOps/FieldStencil.h: rewrite make(stencil,
> >     expr), add make(stencil, expr, domain), kill similar
> >     broken Accumulate stuff, update documentation.
>
>          ^^^^^^^^^^^^^^^^^^^^^^
>
> actually that part is broken.  Leaving it in avoids breaking 
> OffsetReduction test.
>
> Ok with that part retained?  With this and the last patch MPI is also
> regression-free (without looking at particle tests).
>
> Richard.


I guess it's OK to commit.  I tried to follow the logic, but you 
understand this much more than I.  Tomorrow morning, we'll see if the 
regression disappears.

> >     src/Field/tests/ExpressionTest.cpp: use FieldStencilSimple::make
> >     with domain argument, don't take view ourselves.


--
Jeffrey D. Oldham
address@hidden