Re: [freesci-develop] Re: [Scummvm-devel] FreeSCI has been merged in

[Jordi Vilalta]

2009/2/15 Max Horn <address@hidden>:
> Things I am interested in seeing done include:
> * Fixing all warnings
> * Rename source files from *.c to *.cpp, and get rid of the %.c build rule
> in engines/sci/module.mk
> * Update all #include statements to use "" instead of "", and to prefix sci/
> or sci/include as necessary
>  -> then get rid of the evil hack where -I being prepend to CPPFLAGS in
> module.mk
> * Find usage of SCUMMVM #define and resolve them, then in the end stop
> adding -DSCUMMVM to CPPFLAGS in module.mk
> * Rearranging the files under engines/sci: I.e. get rid of include/ subdir
> (just move its contents to engines/sci, at some point at least)
> * Converting stuff from "C pseudo classes" to real classes
> * Replacing various generic FreeSCI stuff by their ScummVM counterparts.
> E.g. don't bother to rewrite engines/sci/include/int_hashmap.h -- instead
> change code to use a HashMap<int, ...> etc.
> * and more, I am too tired to think of it now ;-).

I've started working on it (updating the includes) and removing the -I
hack. Thanks for the detailed TODO, I'll have a look later (need some
sleep)