Re: [PATCH] Use proper SRFI-35 constructs

[Andreas Rottmann]

address@hidden (Ludovic Courtès) writes:

> Hi,
>
> G-Wrap code uses non-conforming SRFI-35 constructs, notably:
>
>   * `define-class' instead of `define-condition-type', often used to
>     create a condition type that inherits from several condition type,
>     which is not part of SRFI-35;
>
>   * `is-a?' instead of `condition-has-type?';
>
>   * assumes that `&condition' and other condition types are GOOPS
>     classes;
>
>   * use the `handle-condition' method.
>
> The attached patch fixes this.  Since Guile 1.8.3 will be shipped with
> a strict SRFI-35 implementation (not GOOPS-based), this patch should
> allow G-Wrap to run fine with Guile 1.8.3.
>
Thanks for the patch; I'll push it soonish.

> BTW, Andreas, did you have a chance to look at my previous patches?
>
AFAICS, I've all but the above patch already merged and pushed to
<http://bazaar.launchpad.net/~rotty/g-wrap/dev>.

Regards, Rotty
-- 
Andreas Rottmann         | address@hidden      | address@hidden | address@hidden
http://rotty.uttx.net    | GnuPG Key: http://rotty.uttx.net/gpg.asc
Fingerprint              | C38A 39C5 16D7 B69F 33A3  6993 22C8 27F7 35A9 92E7
v2sw7MYChw5pr5OFma7u7Lw2m5g/l7Di6e6t5BSb7en6g3/5HZa2Xs6MSr1/2p7 hackerkey.com

09 f9 11 02 9d 74 e3 5b d8 41 56 c5 63 56 88 c0