[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] gnash ChangeLog server/PropertyList.cpp
From: |
Sandro Santilli |
Subject: |
[Gnash-commit] gnash ChangeLog server/PropertyList.cpp |
Date: |
Thu, 13 Dec 2007 19:03:55 +0000 |
CVSROOT: /sources/gnash
Module name: gnash
Changes by: Sandro Santilli <strk> 07/12/13 19:03:55
Modified files:
. : ChangeLog
server : PropertyList.cpp
Log message:
* server/PropertyList.cpp (addGetterSetter): since the function
always returns true, which by documentation means the property
was successfully added, this patch adds an assertion checking
that the just-added property can be successfully looked up.
This assertion seems to fail, so the commit makes Gnash less
robust, but hopefully helps fixing the bug which we keep
occasionally finding. Over here, I can trigger failure of that
assertion by running testsuite/misc-ming.all/loop_test-Runner
(but oddly enough not playing loop_test.swf using Gnash).
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.5163&r2=1.5164
http://cvs.savannah.gnu.org/viewcvs/gnash/server/PropertyList.cpp?cvsroot=gnash&r1=1.26&r2=1.27
Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.5163
retrieving revision 1.5164
diff -u -b -r1.5163 -r1.5164
--- ChangeLog 13 Dec 2007 16:19:46 -0000 1.5163
+++ ChangeLog 13 Dec 2007 19:03:54 -0000 1.5164
@@ -1,5 +1,17 @@
2007-12-13 Sandro Santilli <address@hidden>
+ * server/PropertyList.cpp (addGetterSetter): since the function
+ always returns true, which by documentation means the property
+ was successfully added, this patch adds an assertion checking
+ that the just-added property can be successfully looked up.
+ This assertion seems to fail, so the commit makes Gnash less
+ robust, but hopefully helps fixing the bug which we keep
+ occasionally finding. Over here, I can trigger failure of that
+ assertion by running testsuite/misc-ming.all/loop_test-Runner
+ (but oddly enough not playing loop_test.swf using Gnash).
+
+2007-12-13 Sandro Santilli <address@hidden>
+
* server/parser/video_stream_def.cpp (readDefineVideoFrame): fix
log_debug call (missing params).
* backend/render_handler_agg.cpp, libbase/string_table.h,
Index: server/PropertyList.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/PropertyList.cpp,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -b -r1.26 -r1.27
--- server/PropertyList.cpp 13 Dec 2007 15:56:06 -0000 1.26
+++ server/PropertyList.cpp 13 Dec 2007 19:03:55 -0000 1.27
@@ -348,13 +348,18 @@
// copy flags from previous member (even if it's a normal
member ?)
as_prop_flags& f = a.getFlags();
f = found->getFlags();
+
_props.replace(found, a);
+ assert ( iterator_find(_props, key, nsId) != _props.end() );
+
}
else
{
_props.insert(a);
+ assert ( iterator_find(_props, key, nsId) != _props.end() );
}
+
return true;
}
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Gnash-commit] gnash ChangeLog server/PropertyList.cpp,
Sandro Santilli <=