[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] /srv/bzr/gnash/avm2 r9685: Fix segfault caused by nul
From: |
strk |
Subject: |
Re: [Gnash-commit] /srv/bzr/gnash/avm2 r9685: Fix segfault caused by null objects in the scope stack. |
Date: |
Fri, 14 Nov 2008 21:36:49 +0100 |
On Sat, Nov 15, 2008 at 02:19:01AM +0800, Tom Stellard wrote:
> ------------------------------------------------------------
> revno: 9685
> committer: Tom Stellard <address@hidden>
> branch nick: gnash_dev
> timestamp: Sat 2008-11-15 02:19:01 +0800
> message:
> Fix segfault caused by null objects in the scope stack.
> modified:
> libcore/as_environment.cpp
> libcore/vm/Machine.cpp
> === modified file 'libcore/as_environment.cpp'
> --- a/libcore/as_environment.cpp 2008-11-06 19:04:35 +0000
> +++ b/libcore/as_environment.cpp 2008-11-14 18:19:01 +0000
> @@ -679,6 +679,7 @@
> {
> // const_cast needed due to non-const
> as_object::get_member
> as_object* obj =
> const_cast<as_object*>((*scopeStack)[i-1].get());
> + if(!obj) continue;
Shouldn't we avoid putting NULLs in the scope stack instead ?
How did it get there ?
--strk;
- [Gnash-commit] /srv/bzr/gnash/avm2 r9685: Fix segfault caused by null objects in the scope stack., Tom Stellard, 2008/11/14
- Re: [Gnash-commit] /srv/bzr/gnash/avm2 r9685: Fix segfault caused by null objects in the scope stack.,
strk <=
- Re: [Gnash-commit] /srv/bzr/gnash/avm2 r9685: Fix segfault caused by null objects in the scope stack., Tom Stellard, 2008/11/14
- Re: [Gnash-commit] /srv/bzr/gnash/avm2 r9685: Fix segfault caused by null objects in the scope stack., strk, 2008/11/15
- Re: [Gnash-commit] /srv/bzr/gnash/avm2 r9685: Fix segfault caused by null objects in the scope stack., Tom Stellard, 2008/11/15
- Re: [Gnash-commit] /srv/bzr/gnash/avm2 r9685: Fix segfault caused by null objects in the scope stack., strk, 2008/11/16
- Re: [Gnash-commit] /srv/bzr/gnash/avm2 r9685: Fix segfault caused by null objects in the scope stack., Tom Stellard, 2008/11/17
- Re: [Gnash-commit] /srv/bzr/gnash/avm2 r9685: Fix segfault caused by null objects in the scope stack., strk, 2008/11/17