Re: [Gnash-commit] /srv/bzr/gnash/trunk r11006: create two arrays of init functions, one for as2, and one for as3.

[Rob Savoye]

Benjamin Wolsey wrote:
>>   create two arrays of init functions, one for as2, and one for as3.
> 
> I don't think it's necessary to do this, as the same function can be (at
> the moment will be) used for both versions. There's currently no way at
> all of calling a different function according to the AVM version, and
> it's possible to check within the init function itself whether it's
> called from AVM2 or AVM1 and pick the correct version like that.

  I had noticed you added two arrays in text.am, so thought that was how
you needed it to work for your other AVM2 hacking. I Only changed xml.am
to work this way. It probably barely matters, as long as all the
initializing code gets called for all the classes.

> There also isn't much need to keep the static member init() functions,
> because not all headers should have the class definition. It would be
> simpler just to switch all methods to the *_class_init() version.

  Well, personally, I like all my class definitions in header files, but
don't care heavily about where things get defined. I also don't care
whether we use the *_class_init() or Class::init(), myself, I just want
all the classes we're working on to be consistent. It seemed the
Class::init() way was cleaner, so I thought maybe while we're migrating
all the classes we'd change them to use the Class::init() way.

        - rob -