[Gnash-dev] [patch] Drop non-portable -Wall from all Makefile.am

[Petter Reinholdtsen]

Here is a patch to drop the -Wall compiler flag from all Makefile.am
files.  -Wall is not supported by all compilers, so it is best to set
this flag using configure and not Makefile.am.

Index: backend/Makefile.am
===================================================================
RCS file: /sources/gnash/gnash/backend/Makefile.am,v
retrieving revision 1.17
diff -u -3 -p -r1.17 Makefile.am
--- backend/Makefile.am 29 Mar 2006 05:42:41 -0000      1.17
+++ backend/Makefile.am 29 Mar 2006 06:48:11 -0000
@@ -25,8 +25,6 @@ MP3_CFLAGS = $(MAD_CFLAGS)
 MP3_LIBS = $(MAD_LIBS)
 endif

-AM_CPPFLAGS = -Wall
-
 AM_LDFLAGS =  \
        $(JPEG_LIBS)            \
        $(PNG_LIBS)             \
Index: libamf/Makefile.am
===================================================================
RCS file: /sources/gnash/gnash/libamf/Makefile.am,v
retrieving revision 1.4
diff -u -3 -p -r1.4 Makefile.am
--- libamf/Makefile.am  9 Mar 2006 19:29:05 -0000       1.4
+++ libamf/Makefile.am  29 Mar 2006 06:48:11 -0000
@@ -40,7 +40,6 @@
 AUTOMAKE_OPTIONS =

 AM_CXXFLAGS =  $(CFLAGS) $(SDL_CFLAGS) $(INCLUDES)
-AM_CPPFLAGS = -Wall
 AM_LDFLAGS = \
        ../libbase/libgnashbase.la \
         $(OPENGL_LIBS)      \
Index: libbase/Makefile.am
===================================================================
RCS file: /sources/gnash/gnash/libbase/Makefile.am,v
retrieving revision 1.18
diff -u -3 -p -r1.18 Makefile.am
--- libbase/Makefile.am 29 Mar 2006 05:42:41 -0000      1.18
+++ libbase/Makefile.am 29 Mar 2006 06:48:11 -0000
@@ -41,7 +41,6 @@
 AUTOMAKE_OPTIONS =

 AM_CXXFLAGS = $(SDL_CFLAGS) $(SDL_MIXER_CFLAGS) $(INCLUDES)
-AM_CPPFLAGS = -Wall

 # noinst_LTLIBRARIES = libbase.la
 lib_LTLIBRARIES = libgnashbase.la
Index: libgeometry/Makefile.am
===================================================================
RCS file: /sources/gnash/gnash/libgeometry/Makefile.am,v
retrieving revision 1.12
diff -u -3 -p -r1.12 Makefile.am
--- libgeometry/Makefile.am     29 Mar 2006 05:42:41 -0000      1.12
+++ libgeometry/Makefile.am     29 Mar 2006 06:48:11 -0000
@@ -40,7 +40,6 @@
 AUTOMAKE_OPTIONS =

 AM_CXXFLAGS =  $(CFLAGS) $(SDL_CFLAGS) $(INCLUDES)
-AM_CPPFLAGS = -Wall
 # AM_LDFLAGS  = $(OPENGL_LIBNS) $(SDL_LIBS)

 # noinst_LTLIBRARIES = libgeometry.la
Index: plugin/Makefile.am
===================================================================
RCS file: /sources/gnash/gnash/plugin/Makefile.am,v
retrieving revision 1.16
diff -u -3 -p -r1.16 Makefile.am
--- plugin/Makefile.am  10 Mar 2006 15:15:13 -0000      1.16
+++ plugin/Makefile.am  29 Mar 2006 06:48:11 -0000
@@ -82,7 +82,7 @@ AM_CXXFLAGS = $(INCLUDES)
 # XP_UNIX      This needs to get defined for npapi.h on unix platforms.
 # PLUGIN_TRACE Enable this define to get debug prints whenever the plugin
 #              api gets control.
-AM_CPPFLAGS = -Wall -DPLUGIN_TRACE -DXP_UNIX -DMOZ_X11
+AM_CPPFLAGS = -DPLUGIN_TRACE -DXP_UNIX -DMOZ_X11
 AM_LDFLAGS  = $(X_LIBS) -lX11 -lXi -lXmu \
        $(SDL_LIBS)     \
        $(SDL_MIXER_LIBS)\
Index: plugin/mozilla-sdk/Makefile.am
===================================================================
RCS file: /sources/gnash/gnash/plugin/mozilla-sdk/Makefile.am,v
retrieving revision 1.7
diff -u -3 -p -r1.7 Makefile.am
--- plugin/mozilla-sdk/Makefile.am      5 Mar 2006 01:57:08 -0000       1.7
+++ plugin/mozilla-sdk/Makefile.am      29 Mar 2006 06:48:11 -0000
@@ -24,7 +24,7 @@ INCLUDES = -I.. \
        -I$(srcdir)/include

 AM_CXXFLAGS = $(CFLAGS) $(INCLUDES)
-AM_CPPFLAGS = -Wall  -DPLUGIN_TRACE -DXP_UNIX $(FIREFOX_DEFS)
+AM_CPPFLAGS = -DPLUGIN_TRACE -DXP_UNIX $(FIREFOX_DEFS)
 # AM_LDFLAGS  = $(FIREFOX_LIBS)

 # noinst_LTLIBRARIES = libmozsdk.la
Index: server/Makefile.am
===================================================================
RCS file: /sources/gnash/gnash/server/Makefile.am,v
retrieving revision 1.24
diff -u -3 -p -r1.24 Makefile.am
--- server/Makefile.am  11 Mar 2006 19:24:27 -0000      1.24
+++ server/Makefile.am  29 Mar 2006 06:48:11 -0000
@@ -39,8 +39,6 @@

 AUTOMAKE_OPTIONS =

-AM_CPPFLAGS = -Wall
-
 # noinst_LTLIBRARIES = libserver.la libasobjs.la
 lib_LTLIBRARIES = libgnashserver.la libgnashasobjs.la
 # noinst_SCRIPTS = gen-files.sh
Index: utilities/Makefile.am
===================================================================
RCS file: /sources/gnash/gnash/utilities/Makefile.am,v
retrieving revision 1.14
diff -u -3 -p -r1.14 Makefile.am
--- utilities/Makefile.am       29 Mar 2006 05:42:42 -0000      1.14
+++ utilities/Makefile.am       29 Mar 2006 06:48:11 -0000
@@ -25,7 +25,6 @@ MP3_CFLAGS = $(MAD_CFLAGS)
 MP3_LIBS = $(MAD_LIBS)
 endif

-AM_CPPFLAGS = -Wall
 AM_LDFLAGS = \
        ../backend/libgnashbackend.la \
        ../server/libgnashserver.la \


Please include this patch in a future version of gnash. :)