Re: [Gnash-dev] dangerous use of global data

[strk]

On Sun, Nov 12, 2006 at 03:37:58PM +0100, Bastiaan Jacques wrote:
> On Sunday 12 November 2006 07:26, Hiroyuki Ikezoe wrote:
> > I get the following error.
> >
> > action_buffer.cpp:46: error: conversion from 'const
> > gnash::SWF::SWFHandlers*' to non-scalar typ
> > 'gnash::SWF::SWFHandlers' requested
> > ../../server/swf/ASHandlers.h: In function 'void
> > __static_initialization_and_destruction_0(int, int)':
> > ../../server/swf/ASHandlers.h:268: error:
> > 'gnash::SWF::SWFHandlers::~SWFHandlers()' is private
> > action_buffer.cpp:46: error: within this context
> >
> >
> > To make the destructor of SwFHandler public fixes the error, but I
> > think it is not singleton-linke. I have no more idea about it.
> 
> I've solved the immediate compiler problem by making the singleton 
> stack-allocated (and committed), hoping this won't show up as a leak.

Yes, it's completely fine like that, I didn't realize it was in head.
The problem was with auto_ptr not being a friend of that class, anyway
we don't really need an auto_ptr in that case.
Oh, btw, we don't need the 'const' specification either, return
by const will be ok.

Please consider closing bug #18269

--strk;